Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiShareMangementToShares #40023

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiShareMangementToShares #40023

merged 1 commit into from
Apr 28, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Apr 27, 2022

Description

Improve then steps for suite apiShareManagementToShares

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Apr 27, 2022
@SagarGi SagarGi mentioned this pull request Apr 27, 2022
Closed
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiShareManagementToShares branch from 844ebdd to e6fe0e6 Compare April 28, 2022 09:14
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiShareManagementToShares branch from e6fe0e6 to 7b8ddee Compare April 28, 2022 09:22
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiShareManagementToShares branch from 7b8ddee to 4dec938 Compare April 28, 2022 09:34
kiranparajuli589
kiranparajuli589 reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SagarGi SagarGi requested a review from phil-davis April 28, 2022 09:45
amrita-shrestha
amrita-shrestha reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 031849f into master Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiShareManagementToShares branch April 28, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@sushmita56 sushmita56 Awaiting requested review from sushmita56

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @phil-davis @kiranparajuli589 @amrita-shrestha